Add lookup for ratings in schema.org 'aggregateRating' entities listed on page #913
Conversation
New testcase data & correction to ingredients implemented in #905
There was a problem hiding this comment.
Looks great 👍 - and the test coverage is there to prove that it's working!
It could be interesting to figure out whether any other entity types in the schema.org test metadata involve @id-based lookups -- in other words, any other situations where we could more easily retrieve recipe info. But it doesn't seem to have caused many problems so far, so it's probably fairly rare.
| rating = self._find_entity(item, "AggregateRating") | ||
| if rating: |
There was a problem hiding this comment.
At some point we could optionally reduce the filesize by a few lines by using the walrus operator here -- it looks like I missed one of out two opporunties to do that previously here. It should be safe to do that because this library requires Python 3.8 or greater.
|
Just looking at the test html from maang it looks like a lot (if not all the fields) are available in the graph element. I'm still planning to look into the schema backup check for all the html scraped fields like you mentioned last week. Wonder if there are sites with the graph element that don't utilize schema that could be simplified by implementing something like those for all fields. |
Oh, good point - I'm getting JSON-LD (the graph representation) and schema.org (the entity recipes) confused again, as usual. It's possible that we're missing other items too, yep. The |
Resolves #908
Hey @jayaddison, took a shot at implementing something similar to your author change in #895 for ratings. Let me know how it looks, everything passed on my end.